Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: convert charset by wrapping internal builtin function #29736

Merged
merged 20 commits into from
Nov 17, 2021

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 12, 2021

What problem does this PR solve?

Problem Summary: Close #29863.

This is a refactoring PR. The code changes about built-in functions in TiKV can be minimized.

After the investigation about several built-in functions, I found some common patterns:

  1. Create a new encoding.
  2. Convert the arguments into new charset from utf8.
  3. Apply these changes to the vectorized-version evaluation.

We can extract these patterns into another Sig named builtinToBinarySig(to_binary()) and wrap the cast function as follows:

The rewrite process before this PR:

select some_builtin(arg1, arg2...)

is rewritten to

select some_builtin(cast_as_string(arg1), cast_as_string(arg2)...)

The rewrite process after this PR:

select some_builtin(arg1, arg2...)

is rewritten to

select some_builtin(to_binary(cast_as_string(arg1)), to_binary(cast_as_string(arg2))...)

Then we can maintain a built-in function list to determine which function needs to be wrapped, instead of putting the boilerplates everywhere.

var toBinaryMap = map[string]struct{}{
	ast.Hex: {}, ast.Length: {}, ast.OctetLength: {}, ast.ASCII: {},
	ast.ToBase64: {},
}

What is changed and how it works?

See the code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xiongjiwei
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2021
@tangenta tangenta changed the title [DNM] expression: convert charset by wrapping implicit builtin function expression: convert charset by wrapping implicit builtin function Nov 13, 2021
@tangenta tangenta requested review from hawkingrei, Defined2014, zimulala and xiongjiwei and removed request for hawkingrei November 15, 2021 00:47
@xiongjiwei
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2021

// toBinaryMap contains the builtin functions which arguments need to be converted to the correct charset.
var toBinaryMap = map[string]struct{}{
ast.Hex: {}, ast.Length: {}, ast.OctetLength: {}, ast.ASCII: {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about other functions like upper

Copy link
Contributor Author

@tangenta tangenta Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add them later in the next PR.

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2021
@tangenta tangenta changed the title expression: convert charset by wrapping implicit builtin function expression: convert charset by wrapping internal builtin function Nov 17, 2021
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 41263b9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2021
@ti-chi-bot
Copy link
Member

@tangenta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support internal function to_binary() for new charset
5 participants