-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: convert charset by wrapping internal builtin function #29736
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check_dev_2 |
|
||
// toBinaryMap contains the builtin functions which arguments need to be converted to the correct charset. | ||
var toBinaryMap = map[string]struct{}{ | ||
ast.Hex: {}, ast.Length: {}, ast.OctetLength: {}, ast.ASCII: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about other functions like upper
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add them later in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 41263b9
|
@tangenta: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary: Close #29863.
This is a refactoring PR. The code changes about built-in functions in TiKV can be minimized.
After the investigation about several built-in functions, I found some common patterns:
We can extract these patterns into another
Sig
namedbuiltinToBinarySig
(to_binary()
) and wrap the cast function as follows:The rewrite process before this PR:
select some_builtin(arg1, arg2...)
is rewritten to
select some_builtin(cast_as_string(arg1), cast_as_string(arg2)...)
The rewrite process after this PR:
select some_builtin(arg1, arg2...)
is rewritten to
select some_builtin(to_binary(cast_as_string(arg1)), to_binary(cast_as_string(arg2))...)
Then we can maintain a built-in function list to determine which function needs to be wrapped, instead of putting the boilerplates everywhere.
What is changed and how it works?
See the code.
Check List
Tests
Side effects
Documentation
Release note